add docker file instructions #37
Conversation
README.md
Outdated
| To pull and run the docker image (contains all prerequisites) you can call the following command: | ||
|
|
||
| ``` | ||
| sudo docker run -it --gpus all -v /absolute/path/to/my/data/directory:/home/data oeslle/tapas:1.0 |
There was a problem hiding this comment.
I think we would prefer to include the Dockerfile directly in the repository instad of linking to an external source
There was a problem hiding this comment.
Hi @eisenjulian I added the Dockerfile. However, due to issue #33 tensorflow-probability==0.10.1 must be in the requirements.txt file and tox.ini should have envlist = py36 only.
README.md
Outdated
| ``` | ||
| distribution=$(. /etc/os-release;echo $ID$VERSION_ID) | ||
| curl -s -L https://nvidia.github.io/nvidia-docker/gpgkey | sudo apt-key add - | ||
| curl -s -L https://nvidia.github.io/nvidia-docker/$distribution/nvidia-docker.list | sudo tee /etc/apt/sources.list.d/nvidia-docker.list |
There was a problem hiding this comment.
Is there and official documentation for this steps, it would be better to link directly there and keep the comment in the readme short.
Added official documentation link for Nvidia-docker and Dockerfile instructions.
Added Dockerfile.
There was a problem hiding this comment.
I am very sorry for the delay, but this looks great, thanks a lot for your contribution! Just for reference, can you share in a comment here an example of the logs you get in the console when you run the container?
Also, tox here will run as a prerequisite to build the image, is that correct? Do you know if that is standard?
| && pip install --upgrade setuptools \ | ||
| && pip install --upgrade six \ | ||
| && pip install scipy==1.4.1 \ | ||
| && pip install oauth2client==4.1.2 \ |
There was a problem hiding this comment.
Do we get an error if we remove these two lines or just a warning?
I created a docker image to run TAPAS and wrote down instructions about how to use it at the README.md file.