Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Areebbashir patch 1 #387

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

areebbashir
Copy link
Contributor

@areebbashir areebbashir commented May 11, 2024

Description

Adding appendFirstMessage for non-gemma models.

Fixes # (issue)
crash caused by missing methos

Checklist

Please ensure the following items are complete before submitting a pull request:

  • My code follows the code style of the project.
  • I have updated the documentation (if applicable).
  • I have added tests to cover my changes.

Type of Change

Please check the relevant option below:

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update (non-breaking change which updates documentation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots

If applicable, please add screenshots to help explain your changes.

Additional Notes

Add any additional information or context about the pull request here.

add appendFirstMessage api for non gemma models
add appendFirstMessage api for non-gemma models
Copy link

google-cla bot commented May 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PaulTR PaulTR merged commit 81f24c3 into google-ai-edge:main May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants