Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vg/recorder: drop unneeded field from Canvas. #772

Merged
merged 2 commits into from Sep 2, 2023

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Sep 2, 2023

Fixes #771.

Please take a look.

Fixes gonum#771.

Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.72% 🎉

Comparison is base (8aad608) 73.37% compared to head (29f7e22) 75.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   73.37%   75.10%   +1.72%     
==========================================
  Files          56       58       +2     
  Lines        5180     7423    +2243     
==========================================
+ Hits         3801     5575    +1774     
- Misses       1194     1652     +458     
- Partials      185      196      +11     
Files Changed Coverage Δ
vg/recorder/recorder.go 87.65% <ø> (+1.33%) ⬆️

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbinet sbinet merged commit 342a5ce into gonum:master Sep 2, 2023
8 checks passed
@sbinet sbinet deleted the vg-rec branch September 2, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vg/recorder: invalid/unused Canvas.c field
3 participants