graph: use slices package for sorting and reversing slices #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
from
403c650
to
7110b3b
Compare
|
As discussed in #1956 (comment), I'll more than happy to check if new benchmarks are needed first. |
|
This needs to pick up the changes in master. |
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
from
7110b3b
to
20c5128
Compare
Done. I'll pick them up again if #1953 is merged in. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
+ Coverage 71.46% 72.38% +0.92%
==========================================
Files 489 557 +68
Lines 54288 65108 +10820
==========================================
+ Hits 38797 47130 +8333
- Misses 13086 15376 +2290
- Partials 2405 2602 +197 ☔ View full report in Codecov by Sentry. |
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
from
20c5128
to
b38f902
Compare
kortschak
reviewed
Apr 13, 2024
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
from
1951a3f
to
60d4652
Compare
Okay, commits re-ordered! I intend to rebase and run the benchmarks as soon as prerequisite PR #1953 is merged in. |
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
from
60d4652
to
357673e
Compare
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
3 times, most recently
from
f7672bf
to
8ee84f7
Compare
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
2 times, most recently
from
029bb6e
to
3fca49f
Compare
kortschak
reviewed
May 24, 2024
Thanks for checking! I'm not finished with my benchmarks yet. I ran them last night, but I made a mistake where I ran them on this branch and |
jbduncan
force-pushed
the
617-graph-slices-sort-and-reverse
branch
from
3fca49f
to
44b16ea
Compare
|
Here are the benchmarks. I'm not sure what to make of them. WDYT? Benchmarks |
|
Yeah, that looks like a wash. I think we're fine then. I'll take another proper look on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a modernization change that is not necessarily related to #617 but which was spun out from my attempts at generifying the leaves of
graph. Benchmarks to follow.Blocked by #1940 and #1953.