Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat: Add tests for MeanVariance and PopMeanVariance #1932

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haoxins
Copy link

@haoxins haoxins commented Dec 6, 2023

chore

Please take a look.

Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be done? We have tests for this. Hang on, I missed that we are missing MeanVariance. Please make your tests confirm to the style used in the project (we use table tests for these).

@haoxins
Copy link
Author

haoxins commented Dec 6, 2023

Why does this need to be done? We have tests for this. Hang on, I missed that we are missing MeanVariance. Please make your tests confirm to the style used in the project (we use table tests for these).

done~

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f74f45f) 73.96% compared to head (fd2d12f) 73.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1932      +/-   ##
==========================================
- Coverage   73.96%   73.96%   -0.01%     
==========================================
  Files         533      533              
  Lines       63579    63579              
==========================================
- Hits        47027    47026       -1     
- Misses      13953    13954       +1     
  Partials     2599     2599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants