Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blas/gonum,floats,internal/asm/f32: use L1 norm asm implementation where possible #1889

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kortschak
Copy link
Member

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.01% ⚠️

Comparison is base (93223b4) 74.00% compared to head (3feedd3) 73.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   74.00%   73.99%   -0.01%     
==========================================
  Files         526      527       +1     
  Lines       63210    63211       +1     
==========================================
- Hits        46778    46776       -2     
- Misses      13854    13858       +4     
+ Partials     2578     2577       -1     
Files Changed Coverage Δ
blas/gonum/level1float32.go 0.00% <0.00%> (ø)
internal/asm/f32/stubs_amd64.go 0.00% <0.00%> (ø)
internal/asm/f32/stubs_noasm.go 85.71% <0.00%> (-14.29%) ⬇️
internal/asm/f64/stubs_noasm.go 100.00% <ø> (ø)
blas/gonum/level1float64.go 98.60% <100.00%> (-0.02%) ⬇️
floats/floats.go 99.03% <100.00%> (-0.01%) ⬇️
lapack/gonum/dlangb.go 71.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kortschak kortschak marked this pull request as ready for review September 3, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants