Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GitHub Actions trigger for docker-deploy workflow #2034

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

finagin
Copy link
Contributor

@finagin finagin commented Apr 9, 2024

Fix for #2032

I apologize for the wait and the mistake I made in the previous PR.

docker/metadata-action@v5 can't handle release trigger, but works with tags trigger that are fire when created release.

Now the deployment is configured according to the following scheme:

  • when push to master, creating images with tags master and sha-{sha}
  • when push tags, creating images with tags master, sha-{sha}, latest and all semver variants

Important

Please create hotfix release 5.3.3 after merge PR for generating semver tags for image
Otherwise only the master and sha tags will be created

@dometto dometto merged commit b40af29 into gollum:master Apr 9, 2024
6 checks passed
@dometto
Copy link
Member

dometto commented Apr 9, 2024

I apologize for the wait and the mistake I made in the previous PR.

Absolutely no worries, your contribution is greatly appreciated!

@finagin
Copy link
Contributor Author

finagin commented Apr 11, 2024

@dometto please create release 5.3.3 for generating tags for image

@dometto
Copy link
Member

dometto commented Apr 16, 2024

5.3.3 is now released, pulling with semver tags works! Thanks @finagin

@dometto
Copy link
Member

dometto commented Apr 16, 2024

I did just notice the tags changed from e.g. v5.3 to 5.3. Maybe we should make this change explicit somewhere. Any suggestions for where to document it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants