Improve and localize the "edit" view partial #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwil
changed the title
benjaminwil
force-pushed
the
i18n-improve-edit-page
branch
2 times, most recently
from
a23a076
to
ad59152
Compare
`<button>` elements should not have `href`s. These appear to do nothing. I wrote feature tests to ensure this is true.
Some of this file was indented unconventionally. Now it's not.
benjaminwil
force-pushed
the
i18n-improve-edit-page
branch
from
ad59152
to
d62e6f3
Compare
benjaminwil
requested review from
bartkamphorst and
dometto
and removed request for
bartkamphorst
dometto
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change started to localize the "edit" view partial.
While I was looking at this partial I realized that a) it was indented in an unconventional way and b) its buttons had
hrefattributes, which is not something that<button>s have in valid HTML documents.