Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode based on Client Local System Theme #2002

Closed

Conversation

chiragthakur09
Copy link

@chiragthakur09 chiragthakur09 commented Sep 6, 2023

  1. This PR is addressing the issue Feature request: Dark mode #1893, A new feature to set Dark mode based on Client local systems theme.

When Client System Theme is Set to Light

Screenshot 2023-09-07 at 3 24 28 PM

When Client System Theme is Set to Light

Screenshot 2023-09-07 at 3 25 01 PM

Dialogs had internal css

Screenshot 2023-09-08 at 10 23 00 AM

Replaced with Primers vars

Screenshot 2023-09-08 at 10 23 29 AM
  • Replaced Dialogs internal css with Primer var

@chiragthakur09 chiragthakur09 marked this pull request as draft September 6, 2023 08:45
@chiragthakur09 chiragthakur09 marked this pull request as ready for review September 7, 2023 09:57
@dometto
Copy link
Member

dometto commented Sep 9, 2023

@chiragthakur09 the fix for the Dialogs looks good, but the other items on the to-do list in #1938 still seem unresolved in this PR. Maybe you could copy/paste all the Todo items to this PR? (We can't really merge until the todos are all handled, since the official Docker image is based on what we merge into master -- so Docker users would get an incomplete dark mode, with the Todo items unresolved)

@dometto
Copy link
Member

dometto commented Sep 17, 2023

I'm going to close this for lack of activity, but the fix for our dialogs was very helpful! I'm pushing it to #1938 and have credited the commit to you, @chiragthakur09. If you want to continue implementing the todo items in #1938 we would be very grateful and we can reopen this PR. Otherwise I'm going to assume that development continues in #1938.

@dometto dometto closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants