Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Dark mode #1893

Open
Tracked by #1394
bartkamphorst opened this issue Nov 28, 2022 · 17 comments · May be fixed by #1938
Open
Tracked by #1394

Feature request: Dark mode #1893

bartkamphorst opened this issue Nov 28, 2022 · 17 comments · May be fixed by #1938
Assignees
@chiragthakur09
Labels
CSS styling feature help wanted
Milestone
6.1

Comments

@bartkamphorst
Copy link
Member

Adding a dark mode and being responsive to a client's day/night setting seems like a nice-to-have feature. If there's anyone willing to work on this, a PR would be welcomed.
@bartkamphorst bartkamphorst added this to the 6.1 milestone Nov 28, 2022
@bartkamphorst
Copy link
Member Author

@aleee-idk Is this a feature that you would like to see as well?

@dometto
Copy link
Member

dometto commented Nov 28, 2022

Some pointers perhaps in this comment: #1394 (comment)

@aleee-idk
Copy link
Contributor

I would like to help, but I can´t at the moment, sorry.

thanks for the consideration though.

@Felix2M
Copy link

Felix2M commented Dec 14, 2022

I solved this with custom.css. It is not 100% perfect, but is already pretty good. The only thing that is driving me crazy is that I can not find an option to change the color of the focused line in the ace editor.

This darkmode works only with the darkmode setting of the OS and not with a dedicated button for now.

(As .css files can not be uploaded on github I changed the file extension to txt.)
custom.txt

@dometto
Copy link
Member

dometto commented Dec 20, 2022

After updating to the latest primer, just setting <html data-color-mode="auto" data-dark-theme="dark"> actually seems to be doing a pretty decent job without any custom css. This reports manually needing to change some colour settings, but this would appear not be necessary anymore (maybe because of new changes to primer). I may be missing some details though!

The only thing that is driving me crazy is that I can not find an option to change the color of the focused line in the ace editor.

I think we need to just set a different theme for ACE in lib/gollum/public/gollum/javascript/editor/gollum.editor.js (look for setTheme). Preferabl we would set a default light and a default dark theme for the editor.

@bartkamphorst bartkamphorst mentioned this issue Dec 21, 2022
Open
8 tasks
@dometto dometto linked a pull request Jan 18, 2023 that will close this issue
Draft
12 tasks
@dometto
Copy link
Member

dometto commented Aug 29, 2023

For anyone looking to hack away at this, #1938 is a good place to start!

@chiragthakur09
Copy link

I would like to work on this issue, open to be assigned.

@dometto
Copy link
Member

dometto commented Sep 5, 2023

@chiragthakur09 sure, great! As mentioned in this thread #1938 is probably a good place to start and comes with a little (possible non-exhaustive) todo. Feel free to ping us if we can help you get started!

@chiragthakur09
Copy link

@dometto I wanter to create a new branch and publish my local commits to remote, but not able to public my local newly created branch to remote because I do not have any permission to create and publish new branch to remote.

Will I be granted permission to do so, or is there any other workflow to contribute to this project?

@chiragthakur09
Copy link

chiragthakur09 commented Sep 6, 2023 •
edited

@dometto Please ignore my earlier above comment, I referred the contribution guide, I have forked this gollum repo and progressing.

@bartkamphorst
Copy link
Member Author

I referred the contribution guid, I have forked this gollum repo and progressing.

Excellent, keep up the good work!

This was referenced Sep 7, 2023
Closed
Closed
@chiragthakur09
Copy link

@chiragthakur09 sure, great! As mentioned in this thread #1938 is probably a good place to start and comes with a little (possible non-exhaustive) todo. Feel free to ping us if we can help you get started!

Thank you sharing the TODO list it was helping to Identify areas to be fixed.

@dometto
Copy link
Member

dometto commented Sep 8, 2023 •
edited

Thanks for working on this @chiragthakur09! Are you sure you have pushed all your commits to the PR branch already? I see a fix for the dialogs issue in the Todo, but not yet for the other issues. Or maybe I misunderstood and you are still working on those!

@svoop
Copy link
Contributor

svoop commented Jan 22, 2024

@chiragthakur09 Thanks for working on this, I'd really love to see dark mode especially during the (northern hemisphere) winter months. 😉 This appears to have stalled a little, maybe you don't have time to continue with this? In this case, would you mind pushing your work so someone else might chime in? (Unfortunately, I'm not very gifted with CSS, so not the right person to put on the hat, but I might tackle one or two minor issues from the list.)

@chiragthakur09
Copy link

@chiragthakur09 Thanks for working on this, I'd really love to see dark mode especially during the (northern hemisphere) winter months. 😉 This appears to have stalled a little, maybe you don't have time to continue with this? In this case, would you mind pushing your work so someone else might chime in? (Unfortunately, I'm not very gifted with CSS, so not the right person to put on the hat, but I might tackle one or two minor issues from the list.)

Yes, sure.
Please if someone else wants to pick this story, that would be good.

@svoop
Copy link
Contributor

svoop commented Jan 22, 2024

@chiragthakur09 There is no commit after Sep 8 on https://github.com/chiragthakur09/gollum/commits/dark-mode-support/ – am I looking at the right place here?

@dometto
Copy link
Member

dometto commented Jan 22, 2024

@svoop I think #1938 might be the most advanced attempt t this point, but of course if you have @chiragthakur09 more commits to share that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiragthakur09 chiragthakur09

Labels
CSS styling feature help wanted
Projects
None yet
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

Activate dark mode repotag/gollum
6 participants
@svoop @dometto @bartkamphorst @chiragthakur09 @aleee-idk @Felix2M