python module compatibility with 3.x (and 2.6+) #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling pre-2.6 requires getting rid of that
bytesobject.h
compat header and defining what's needed manually. I figured to leave it alone until someone asks for pre-2.6.I have tested this a little. I see no compiler errors or warnings and opening a channel and getting from it works as expected. the most confusing thing was python's refcounting and whether the incref was really needed. I believe all the changes (in particular the
PyLong_FromLong
uses) are okay.I'm planning changes to the python side that make get/put a little easier (create buffer implicitly, ...) that will get its own pull request.