Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI bugs #20364

Merged
merged 1 commit into from Apr 26, 2024
Merged

Fix UI bugs #20364

merged 1 commit into from Apr 26, 2024

Conversation

xuelichao
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20362
Fixes #20351
Fixes #20350
Fixes #20338
Fixes #20335
Fixes #20326
Fixes #20323
Fixes #20322

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (b7b8847) to head (3298263).
Report is 160 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20364       +/-   ##
===========================================
- Coverage   67.56%   46.32%   -21.24%     
===========================================
  Files         991      247      -744     
  Lines      109181    13745    -95436     
  Branches     2719     2828      +109     
===========================================
- Hits        73768     6368    -67400     
+ Misses      31449     7051    -24398     
+ Partials     3964      326     -3638     
Flag Coverage Δ
unittests 46.32% <ø> (-21.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@xuelichao xuelichao force-pushed the sbom-ui branch 6 times, most recently from 2acbd7f to 0e0850f Compare April 26, 2024 03:13
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xuelichao xuelichao force-pushed the sbom-ui branch 2 times, most recently from 1b3de86 to ff72508 Compare April 26, 2024 05:33
Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao merged commit dee73a4 into goharbor:main Apr 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment