Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not delete accessory relationship while still referenced #20360

Merged
merged 4 commits into from Apr 30, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Apr 25, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#20377

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.33%. Comparing base (b7b8847) to head (065e70f).
Report is 170 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20360       +/-   ##
===========================================
- Coverage   67.56%   46.33%   -21.23%     
===========================================
  Files         991      247      -744     
  Lines      109181    13749    -95432     
  Branches     2719     2830      +111     
===========================================
- Hits        73768     6371    -67397     
+ Misses      31449     7054    -24395     
+ Partials     3964      324     -3640     
Flag Coverage Δ
unittests 46.33% <ø> (-21.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang enabled auto-merge (squash) April 30, 2024 01:09
@MinerYang MinerYang merged commit d01dfd4 into goharbor:main Apr 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants