Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename harbor.sbom to sbom.harbor #20359

Merged
merged 2 commits into from May 2, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Apr 25, 2024

fixes #20350

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 25, 2024 02:57
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 25, 2024
@stonezdj stonezdj assigned wy65701436 and unassigned AllForNothing and chlins Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (b7b8847) to head (b600b6d).
Report is 171 commits behind head on main.

❗ Current head b600b6d differs from pull request most recent head 924c112. Consider uploading reports for the commit 924c112 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20359       +/-   ##
===========================================
- Coverage   67.56%   46.32%   -21.25%     
===========================================
  Files         991      247      -744     
  Lines      109181    13749    -95432     
  Branches     2719     2830      +111     
===========================================
- Hits        73768     6369    -67399     
+ Misses      31449     7056    -24393     
+ Partials     3964      324     -3640     
Flag Coverage Δ
unittests 46.32% <ø> (-21.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@stonezdj stonezdj enabled auto-merge (squash) April 25, 2024 09:37
@stonezdj stonezdj force-pushed the 24apr25_rename_sbom_harbor branch 2 times, most recently from ad102f7 to 5cdbdc6 Compare April 28, 2024 02:11
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24apr25_rename_sbom_harbor branch 2 times, most recently from 9a41ba0 to 9ae5c0d Compare April 30, 2024 01:08
@stonezdj stonezdj force-pushed the 24apr25_rename_sbom_harbor branch from 9ae5c0d to f08c4b8 Compare May 1, 2024 07:10
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24apr25_rename_sbom_harbor branch from f08c4b8 to b600b6d Compare May 1, 2024 07:11
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj merged commit 8431c9c into goharbor:main May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update the type of generated sbom from harbor.sbom to sbom.harbor
6 participants