Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support registry http.relativeurls in harbor.yml #20339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tahacodes
Copy link

@tahacodes tahacodes commented Apr 23, 2024

Support registry http.relativeurls in harbor.yml

Hi there, in this PR, I have attempted to resolve one of the issues we’ve been having with Harbor for a long time. After each upgrade, we have to manually set http.relativeurls: true in common/config/registry/config.yml because this setting doesn’t exist in the harbor.yml and it gets overwritten when the ./install script is executed.
Setting relativeurls is essential for our kind of workflow and the absence of it causes unknown blob errors while pushing images.
This issue has been fixed in harbor-helm here and in this PR, the relativeurls setting becomes available in harbor.yml.

Thank you for considering this change. If there are any suggestions or problems I need to address, I’m available.

Issue being fixed

Fixes #12135

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Taha Farahani <tahacodes@proton.me>
@tahacodes tahacodes marked this pull request as ready for review April 23, 2024 09:44
@tahacodes tahacodes requested a review from a team as a code owner April 23, 2024 09:44
Signed-off-by: Taha Farahani <tahacodes@proton.me>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.12%. Comparing base (b7b8847) to head (a9a6d5c).
Report is 179 commits behind head on main.

❗ Current head a9a6d5c differs from pull request most recent head e791c14. Consider uploading reports for the commit e791c14 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20339      +/-   ##
==========================================
+ Coverage   67.56%   69.12%   +1.55%     
==========================================
  Files         991      795     -196     
  Lines      109181    99190    -9991     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68561    -5207     
+ Misses      31449    26903    -4546     
+ Partials     3964     3726     -238     
Flag Coverage Δ
unittests 69.12% <ø> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 320 files with indirect coverage changes

@tahacodes
Copy link
Author

tahacodes commented Apr 24, 2024

I just noticed that i was referring to issue 174 in the original description which is not related to this PR, sorry for the confusion.
Also i can not set labels (release-note/enhancement probably?) to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants