New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make swagger download automatically select architecture #19780
base: main
Are you sure you want to change the base?
Conversation
This does not work for all architectures, but at least amd64 and arm64. I could also add a switch statement, but ARM64 seems to be the most important arch to implement right now (goharbor#3505). Signed-off-by: Aaron Dewes <aaron.dewes@protonmail.com>
this command |
Could you please contribute in the following repo to support Harbor in ARM: Thanks |
The container is always a Linux container, isn't it? And https://github.com/goharbor/harbor-arm seems unmaintained. In my opinion, a second repo for arm is unnecessary considering how small the changes for arm64 support would need to be (This PR + another 10 line patch). So please reopen or reconsider this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19780 +/- ##
===========================================
+ Coverage 45.30% 67.56% +22.26%
===========================================
Files 244 991 +747
Lines 13333 109172 +95839
Branches 2720 2720
===========================================
+ Hits 6040 73763 +67723
- Misses 6993 31444 +24451
- Partials 300 3965 +3665
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Comprehensive Summary of your change
This does not work for all architectures, but at least amd64 and arm64. I could also add a switch statement, but ARM64 seems to be the most important arch to implement right now (#3505).
Issue being fixed
Helps towards #3505
Please indicate you've done the following: