Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add acr ee support #19658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: add acr ee support #19658

wants to merge 1 commit into from

Conversation

njucjc
Copy link

@njucjc njucjc commented Dec 1, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Feat: add acr ee support

Issue being fixed

Fixes #19659

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@njucjc
Copy link
Author

njucjc commented Dec 1, 2023

@njucjc njucjc force-pushed the support_acr_ee branch 3 times, most recently from 0a6ec17 to b3c42d6 Compare December 1, 2023 14:39
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: Patch coverage is 8.36237% with 263 lines in your changes are missing coverage. Please review.

Project coverage is 70.52%. Comparing base (a3e1b1e) to head (efd7515).
Report is 62 commits behind head on main.

❗ Current head efd7515 differs from pull request most recent head e384916. Consider uploading reports for the commit e384916 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19658      +/-   ##
==========================================
+ Coverage   67.45%   70.52%   +3.07%     
==========================================
  Files         996      748     -248     
  Lines      109773    96001   -13772     
  Branches     2720        0    -2720     
==========================================
- Hits        74044    67704    -6340     
+ Misses      31747    24632    -7115     
+ Partials     3982     3665     -317     
Flag Coverage Δ
unittests 70.52% <8.36%> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/reg/adapter/aliacr/types.go 0.00% <ø> (ø)
src/pkg/reg/adapter/aliacr/auth.go 23.52% <0.00%> (+6.13%) ⬆️
src/pkg/reg/adapter/aliacr/adapter.go 39.92% <29.62%> (+2.02%) ⬆️
src/pkg/reg/adapter/aliacr/openapi.go 0.00% <0.00%> (ø)

... and 270 files with indirect coverage changes

@wy65701436
Copy link
Contributor

Thanks, @njucjc for your contribution.

I have a couple of basic questions:

  • Is it possible to set up a staging environment of ACR EE for our validation and regression purposes?
  • Also, considering that the replication adapter ships with harbor-core, which requires CVE and bug fixes, would you be responsible for maintaining this adapter?

@wy65701436 wy65701436 added the release-note/new-feature New Harbor Feature label Dec 4, 2023
@njucjc
Copy link
Author

njucjc commented Dec 4, 2023

Thanks, @njucjc for your contribution.

I have a couple of basic questions:

  • Is it possible to set up a staging environment of ACR EE for our validation and regression purposes?
  • Also, considering that the replication adapter ships with harbor-core, which requires CVE and bug fixes, would you be responsible for maintaining this adapter?

@wy65701436

  • Of course, I can provide an ACR EE instance for regression verification. What is the best way for me to provide this ACR EE instance for you to verify?it has been verified by myself.
  • Sure, It's my honor to maintain this adapter.

By the way, I fix some UTTEST errors

@njucjc njucjc force-pushed the support_acr_ee branch 2 times, most recently from 4942da0 to efd7515 Compare December 4, 2023 09:04
@njucjc
Copy link
Author

njucjc commented Dec 7, 2023

any comments?

@njucjc
Copy link
Author

njucjc commented Dec 12, 2023

Thanks, @njucjc for your contribution.
I have a couple of basic questions:

  • Is it possible to set up a staging environment of ACR EE for our validation and regression purposes?
  • Also, considering that the replication adapter ships with harbor-core, which requires CVE and bug fixes, would you be responsible for maintaining this adapter?

@wy65701436

  • Of course, I can provide an ACR EE instance for regression verification. What is the best way for me to provide this ACR EE instance for you to verify?it has been verified by myself.
  • Sure, It's my honor to maintain this adapter.

By the way, I fix some UTTEST errors

@wy65701436 I send an ACR EE acount for you in email

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

Signed-off-by: njucjc <njucjc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't support to sync image to ACR EE repositry
5 participants