Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling flatenning on empty namespace #19321

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

NicoForce
Copy link

@NicoForce NicoForce commented Sep 6, 2023

Comprehensive Summary of your change

  • Removes the if condition that skips flatenning when namespace length is 0.
  • Adds case in switch for dstRepoPrefix value when namespace length is 0.
  • Removed empty namespace test.
  • Added 6 new tests for empty namespace behavior.

Issue being fixed

Fixes #19319

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: NicoForce <github.hhedq@simplelogin.com>
Signed-off-by: NicoForce <github.hhedq@simplelogin.com>
@NicoForce
Copy link
Author

@wy65701436 @chlins Is there anything missing that I can do to move this forward? Please let me know, thanks!

@Vad1mo Vad1mo enabled auto-merge (squash) October 23, 2023 10:12
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate and confirm that your PR is backward compatible and won't break existing setups when applied?
Also the impact on the docs.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.79%. Comparing base (a3e1b1e) to head (0a6432f).
Report is 22 commits behind head on main.

❗ Current head 0a6432f differs from pull request most recent head 8a56174. Consider uploading reports for the commit 8a56174 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19321       +/-   ##
===========================================
- Coverage   67.45%   44.79%   -22.66%     
===========================================
  Files         996      244      -752     
  Lines      109773    13416    -96357     
  Branches     2720     2752       +32     
===========================================
- Hits        74044     6010    -68034     
+ Misses      31747     7100    -24647     
+ Partials     3982      306     -3676     
Flag Coverage Δ
unittests 44.79% <ø> (-22.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 779 files with indirect coverage changes

@Vad1mo Vad1mo added the release-note/update Update or Fix label Oct 23, 2023
@NicoForce
Copy link
Author

Can you elaborate and confirm that your PR is backward compatible and won't break existing setups when applied? Also the impact on the docs.

It will break existing setups, for those using the empty namespace option, they would need to change to adding the value they were already using to the project name, which is the current default behavior.

The section that needs to be improved in the docs is this one, will create a PR for it.

Signed-off-by: NicoForce <32383958+NicoForce@users.noreply.github.com>
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Dec 24, 2023
@NicoForce
Copy link
Author

Commenting to remove staleness

@github-actions github-actions bot removed the Stale label Dec 26, 2023
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Feb 25, 2024
@NicoForce
Copy link
Author

Commenting to remove stale label

@mkhpalm
Copy link

mkhpalm commented Mar 20, 2024

I would like to see this merged since the existing behavior feels/acts more like a bug than a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flattening not working with empty namespace (Replication rule for ECR)
8 participants