New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling flatenning on empty namespace #19321
base: main
Are you sure you want to change the base?
Enabling flatenning on empty namespace #19321
Conversation
Signed-off-by: NicoForce <github.hhedq@simplelogin.com>
07d79a8
to
21281d0
Compare
Signed-off-by: NicoForce <github.hhedq@simplelogin.com>
@wy65701436 @chlins Is there anything missing that I can do to move this forward? Please let me know, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate and confirm that your PR is backward compatible and won't break existing setups when applied?
Also the impact on the docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19321 +/- ##
===========================================
- Coverage 67.45% 44.79% -22.66%
===========================================
Files 996 244 -752
Lines 109773 13416 -96357
Branches 2720 2752 +32
===========================================
- Hits 74044 6010 -68034
+ Misses 31747 7100 -24647
+ Partials 3982 306 -3676
Flags with carried forward coverage won't be shown. Click here to find out more. |
It will break existing setups, for those using the empty namespace option, they would need to change to adding the value they were already using to the project name, which is the current default behavior. The section that needs to be improved in the docs is this one, will create a PR for it. |
Signed-off-by: NicoForce <32383958+NicoForce@users.noreply.github.com>
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Commenting to remove staleness |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Commenting to remove stale label |
I would like to see this merged since the existing behavior feels/acts more like a bug than a feature. |
Comprehensive Summary of your change
Issue being fixed
Fixes #19319
Please indicate you've done the following: