Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis sentinel mode supports setting password #19304

Closed
wants to merge 1 commit into from

Conversation

lilongfeng0902
Copy link

@lilongfeng0902 lilongfeng0902 commented Sep 4, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

In actual production, we use the sentinel mode of the harbor redis component and find that the password setting is not supported, the reason is that in the which is modified about PR.

Issue being fixed

Fixes #(issue)
none
release-note/enhancement
Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
@lilongfeng0902
Copy link
Author

@MinerYang Can you take the time to review the PR? Thanks.

@Kajot-dev
Copy link

It would be really nice to have this and also #19565

@lilongfeng0902
Copy link
Author

It would be really nice to have this and also #19565

I have checked the PR you mentioned, but it does not solve the problem of supporting password setting in Sentinel mode. You can follow my ideas and check the code again. Thanks.

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Jan 15, 2024
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants