fix: 馃悰 chartmuseum and registry aliyun oss endpoint format #556
Conversation
Signed-off-by: wind2008hxy <wind2008hxy@gmail.com>
| @@ -232,6 +232,7 @@ persistence: | |||
| accesskeysecret: accesskeysecret | |||
| region: regionname | |||
| bucket: bucketname | |||
| ### endpoint format: [bucket].[region].aliyuncs.com or [bucket].[region]-internal.aliyuncs.com | |||
There was a problem hiding this comment.
An endpoint which defaults to [bucket].[region].aliyuncs.com or [bucket].[region]-internal.aliyuncs.com (when internal=true). You can change the default endpoint by changing this value.
Per the doc , the format [bucket].[region].aliyuncs.com or [bucket].[region]-internal.aliyuncs.com is the default value of endpoint. So this isn't the required format for the customized endpoint?
| @@ -99,7 +99,11 @@ data: | |||
| STORAGE_ALIBABA_PREFIX: {{ $storage.oss.rootdirectory }} | |||
| {{- end }} | |||
| {{- if $storage.oss.endpoint }} | |||
| STORAGE_ALIBABA_ENDPOINT: {{ $storage.oss.endpoint }} | |||
| STORAGE_ALIBABA_ENDPOINT: {{ $storage.oss.endpoint | trimPrefix $storage.oss.bucket | trimPrefix "." }} | |||
There was a problem hiding this comment.
If the endpoint is specified, shouldn't we just use it as the STORAGE_ALIBABA_ENDPOINT directly?
There was a problem hiding this comment.
If the
endpointis specified, shouldn't we just use it as theSTORAGE_ALIBABA_ENDPOINTdirectly?
yes,but charmuseum endpoint format not include bucket name
|
yes锛宑harmuseum endpoint format not include bucket name |
(cherry picked from commit 5e2e7df)
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
Still relevant |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
https://docs.docker.com/registry/storage-drivers/oss/
regionandbucketis required, you must set the value invalues.yaml.endpointdefault is emptyso when the
endpointis empty, chartmuseum will get the empty endpoint.harbor-helm/templates/chartmuseum/chartmuseum-cm.yaml
Line 102 in 55598b1
but charmuseum endpoint format not include
bucket