Add lifecycle to core dpl #1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MinerYang @zyyw |
|
Hi @derekcha , thanks for contributing to harbor-helm. Could you please help to resolve the |
zyyw
previously approved these changes
Apr 12, 2024
Vad1mo
requested changes
Apr 12, 2024
derekcha
force-pushed
the
add-lifecycle-setting
branch
from
2858fb3
to
59f9955
Compare
Signed-off-by: derek <derek@dunamu.com>
Signed-off-by: derek <derek@dunamu.com>
…, trivy Signed-off-by: derek <derek@dunamu.com>
derekcha
force-pushed
the
add-lifecycle-setting
branch
from
4ab04f8
to
d0cee30
Compare
|
@zyyw Are you still discussing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using Harbor so well, and I'm glad I was able to raise a PR like this.
What improvements does these changes make?
A 504 or EOF error occurred when rolling while using Harbor.
It looks like the pods aren't being cleaned up properly on shutdown (possibly because there is a port after AWS LB).
So I tested randomly setting the prestop(sleep 60) lifecycle for containers in Harbor Core and no errors occurred.
So, I am uploading a PR so that lifecycle settings can be done through this chart.
I will write down the link to the issue I registered below.
#1722