add support for configuring internal domain #1712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkukral
changed the title
tomkukral
changed the title
|
Seems to be working fine on my testing setup. I will update PR if any error is discovered. |
tomkukral
changed the title
Signed-off-by: Tomáš Kukrál <noreply@6shore.net>
|
@tomkukral isn't this going into the same direction as #1706? |
Feature implemented in #1706 is different, IMHO.#1641
I'm running testing PoC on top of my branch so feel free to ping me if I should run any specific test. |
|
Thanks for contributing to harbor-helm. This might be a too specific change. closing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option can be beneficial if certificates aren't allowed to use bare domain.