New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prometheusRule #1703
base: main
Are you sure you want to change the base?
feat: add prometheusRule #1703
Conversation
c706f62
to
7fd5784
Compare
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
7fd5784
to
d1cc9dd
Compare
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
@micborens this is probably related to the PR #1635 |
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
@Allex1 I appreciate your first pr but it's not flexible following our usage in my company and any case for the community. That's why I opened this PR. |
This generally looks good, I need to test it myself and give it a try, but I support that approach! |
@micborens tbh the extra labels and annotations for each alert group seem unnecessary but it's not my call. If you add Grafana support to this pr I'm willing to close mine in favor of this . |
892f929
to
e6ee715
Compare
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
e6ee715
to
fa75afb
Compare
Hello @Allex1 I've included your Grafana dashboard file in my PR.
Having the ability to enrich or not a resource on Kubernetes is needed when the chart is opensource. And I need it for my usage :) |
Signed-off-by: Michael Borens <michael.borens@contentsquare.com>
fa75afb
to
87e9f49
Compare
Hello @Vad1mo do you think we can merge this PR? |
IMO, it's good, but you need to address the open points. |
Hi @micborens @Allex1 , We are aware of many requirements of PrometheusRule for harbor and by having this let it more convenient to allow users to visualizing metrics.
So, we are thinking if it's possible to make it as a plugin which should have a standalone repository to co-work on demand, and possibly need a process to move existing metrics-svcmon part along with it. We will be appreciate if you are willing to continuing contributing this part for our community! Best, |
Hello @Vad1mo I understood your point to have a value as clear as posssible. That's why I've put some comments in the files to explain all parts. @MinerYang prometheus operator looks become a standard on kubernetes. however it's secure with check condition (presence of crds).
You are probably referring to subchart or libraries. I don't think it is usefull here except you want to reuse it in another chart. I reiterate my interest in the monitoring part and I am ready to contribute to maintaining the feature. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Default alerts are based on what I found in this PR
I'm ok to maintain this part of the helm if needed.