remove enableMigrateHelmHook #1699
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set enableMigrateHelmHook always be true to avoid any migration failure, especially in the case of large mount data. Signed-off-by: wang yan <wangyan@vmware.com>
Vad1mo
requested changes
Feb 11, 2024
|
The purpose behind introducing this setting was to address situations where migration takes more than 60 seconds to complete. When users encounter this issue, they are required to enable this option and initiate the migration process again. There is no harm in enabling it by default, and there is no need to include this option in the values.yaml file for users to decide whether to enable it or not. |
Vad1mo
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set enableMigrateHelmHook always be true to avoid any migration failure, especially in the case of large mount data.