New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting of additional labels for services #1678
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sebastian Stauch <dev@iostat.de>
Signed-off-by: Sebastian Stauch <dev@iostat.de>
@sebidude , thank you for the contribution to harbor-helm! Could you please justify a little bit why you would like to allow setting of additional labels for services? |
It will enable us to automatically configure external loadbalancers where their controller needs certain labels in the services. |
Thanks! @sebidude , could you please update the README.md for this configuration? |
Signed-off-by: Sebastian Stauch <dev@iostat.de>
0b3f76d
to
e8d4fa3
Compare
Readme is updated. Let me know if you need anything else. Thanks |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
What a pity. Now there are merge conflicts. |
This PR enables users to set labels on all services.