Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of additional labels for services #1678

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sebidude
Copy link

This PR enables users to set labels on all services.

Signed-off-by: Sebastian Stauch <dev@iostat.de>
Signed-off-by: Sebastian Stauch <dev@iostat.de>
@zyyw
Copy link
Collaborator

zyyw commented Jan 24, 2024

@sebidude , thank you for the contribution to harbor-helm! Could you please justify a little bit why you would like to allow setting of additional labels for services?
Thanks again.

@sebidude
Copy link
Author

It will enable us to automatically configure external loadbalancers where their controller needs certain labels in the services.
For us, it would have been enough to just set the labels on the harbor service, but for filtering in logs and metrics, it can also come handy to have labels on all of them.
Let me know if you need more info on this.

@zyyw
Copy link
Collaborator

zyyw commented Jan 25, 2024

Thanks! @sebidude , could you please update the README.md for this configuration?

Signed-off-by: Sebastian Stauch <dev@iostat.de>
@sebidude
Copy link
Author

sebidude commented Feb 1, 2024

Readme is updated. Let me know if you need anything else.

Thanks

@Vad1mo Vad1mo requested a review from zyyw February 1, 2024 15:33
Copy link

github-actions bot commented Apr 2, 2024

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Apr 2, 2024
@sebidude
Copy link
Author

sebidude commented Apr 2, 2024

What a pity. Now there are merge conflicts.

@github-actions github-actions bot removed the Stale label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants