Allow customization of annotations on services exposing metrics #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyyw
reviewed
Jun 15, 2023
|
Thanks for contributing to harbor-helm. Please also follow this instruction:
|
Signed-off-by: afreyermuth98 <anthofreyer@gmail.com>
Signed-off-by: afreyermuth98 <anthofreyer@gmail.com>
afreyermuth98
force-pushed
the
evol/svcAnnotations
branch
from
93b9272
to
43180f0
Compare
|
Up :) |
afreyermuth98
force-pushed
the
evol/svcAnnotations
branch
from
a45bdb1
to
43180f0
Compare
|
Hi @zyyw ... would be great if this PR could get merged - we would also like to use this feature for auto-scraping metrics. Thanks & cheers |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Vad1mo
approved these changes
Feb 14, 2024
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to annotate the services that expose metrics to scrape them.