New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
htpasswdString doc fix - resolves #1210 #1242
base: main
Are you sure you want to change the base?
htpasswdString doc fix - resolves #1210 #1242
Conversation
Signed-off-by: Richard Sufliarsky <richard.sufliarsky@gmail.com>
# Login and password in htpasswd string format. May come in handy when integrating with tools like argocd or flux. | ||
# This allows the same line to be generated each time the template is rendered, instead of the `htpasswd` function from helm, | ||
# which generates different lines each time because of the salt. | ||
# Do not comment out `registry.credentials.username` and `registry.credentials.password` as these are used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an additional comment:
If using htpasswdString, it should be consistent with using credentials.username and credentials.password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zyyw, done.
Signed-off-by: Richard Sufliarsky <richard.sufliarsky@gmail.com>
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Signed-off-by: Richard Sufliarsky richard.sufliarsky@gmail.com