Add recommended labels for each components #1051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhoLee
force-pushed
the
feature-harbor-helm-labels
branch
from
fd00de9
to
872a927
Compare
|
@ninjadq @ywk253100 |
dioguerra
reviewed
Sep 28, 2021
JhoLee
force-pushed
the
feature-harbor-helm-labels
branch
2 times, most recently
from
457cc13
to
91ffe27
Compare
|
Any updates? |
|
FYI, Changing selector labels will require forced redeployment of all components as that field is immutable, so it'll be a semi-breaking change. Might want to look at not doing that. |
|
could you please squash the commits first and then rebase the code as well. @JhoLee |
|
@sidewinder12s why would it be a concern since this PR is backward compatible. |
|
@zyyw As far as I'd seen, you cannot change the labels used in selectors after a deployment, it'll error out saying its a immutable field. So if this lands, users cannot deploy it without either force applying it or tearing down their existing deployments. |
Signed-off-by: Jooho Lee <jhlee@si-analytics.ai>
JhoLee
force-pushed
the
feature-harbor-helm-labels
branch
from
91ffe27
to
b19a386
Compare
Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for chartmuseum Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for core Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for databasae Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for exporter Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for jobservice Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for nginx Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for notary Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for portal Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for redis Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for registry Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Add recommended labels for trivy Signed-off-by: Jooho Lee <jhlee@si-analytics.ai> Fix typo in templates/core/core-dpl.yaml Signed-off-by: Joo-Ho Lee(이주호, Jho) <jooho.lee@outlook.kr>
JhoLee
force-pushed
the
feature-harbor-helm-labels
branch
from
b19a386
to
b1a1941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recommended labels for each components of Harbor, and common recommended labels by _helpers.tpl
Reference: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Resolves #1471 #1045