Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload's labels isn't following the recommendation of labels from Kubernetes. #1045

Open
JhoLee opened this issue Sep 5, 2021 · 5 comments
Assignees

Comments

@JhoLee
Copy link

JhoLee commented Sep 5, 2021

tl;dr
Suggesting Harbor Helm Chart to follow the [Kubernetes Labels Recommendation](backward compatibility).


I'm using Harbor and many apps with helm.
And I use their kubernetes labels usefully like;

  1. Collecting metrics with Prometheus.
  2. Managing workloads.

But I knew that Harbor Helm has not follwed Kubernetes' label recommendation.
(More information)

So I suggest Harbor to follow this recommendation.
Or I will commit it by myself, and I'll request for review.

Thank you.

@JhoLee JhoLee changed the title Workload's labels doesn't follow the recommendation of labels from Kubernetes. Workload's labels isn't following the recommendation of labels from Kubernetes. Sep 8, 2021
@ninjadq
Copy link
Member

ninjadq commented Sep 16, 2021

Hi @JhoLee , thank you for mention this, could you help to commit a PR to add this label to harbor-helm, we already have some similar labels but not follow the k8s recommendation, you should keep them and add the new ones. Because some user may depend those labels in production

@ninjadq ninjadq self-assigned this Sep 16, 2021
@JhoLee
Copy link
Author

JhoLee commented Sep 17, 2021

@ninjadq OK. I'll commit it with backward compatibility.

@JhoLee
Copy link
Author

JhoLee commented Sep 21, 2021

@ninjadq I committed those labels with backward compatibility!

@zyyw zyyw assigned zyyw and unassigned ninjadq Jan 13, 2022
@martinnirtl
Copy link

Hello!! Any update on this?

@billabongrob
Copy link

Yeah, curious as well. Seems like none of the deployments or statefulsets inherit any of these labels. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants