Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the Project flow in cli #35

Merged
merged 10 commits into from May 8, 2024
Merged

Conversation

amands98
Copy link
Contributor

@amands98 amands98 commented Apr 1, 2024

  • List
    image

  • Delete

image

  • Create

image

  • View

In the view where we display project information, we will also list the scanners and repositories associated with that project.

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Signed-off-by: amands98 <amandeepsm.in@gmail.com>
@amands98
Copy link
Contributor Author

amands98 commented Apr 3, 2024

@Vad1mo

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that the harbor CLIs should also be usable in non-interactive mode, In CI/CD pipelines, in scripts. piping in yaml/json and outputting jsons/yaml are equally important.

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Signed-off-by: amands98 <amandeepsm.in@gmail.com>
@amands98 amands98 changed the title feat: improve the Project flow in cli feat: improve the Project/Registry flow in cli Apr 20, 2024
@amands98
Copy link
Contributor Author

amands98 commented Apr 20, 2024

Test Case :

  • Project

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Signed-off-by: amands98 <amandeepsm.in@gmail.com>
@amands98 amands98 changed the title feat: improve the Project/Registry flow in cli feat: improve the Project flow in cli Apr 22, 2024
@amands98
Copy link
Contributor Author

We handle projects in this PR only. Will open a separate one for the registry. I've also added subcommands logs to the project command recently.

@amands98
Copy link
Contributor Author

keep in mind that the harbor CLIs should also be usable in non-interactive mode, In CI/CD pipelines, in scripts. piping in yaml/json and outputting jsons/yaml are equally important.

It will works both ways.

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
@amands98
Copy link
Contributor Author

amands98 commented May 2, 2024

added table for project logs -
image

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
@Vad1mo Vad1mo merged commit 2f91494 into goharbor:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants