Mark node as down if unable to dial control conn #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this if during restart the resources assigned to node change, the driver does not update this. That could lead to outdated information about threads/shards.
|
@martin-sucha Could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if connection to the node failed, information about that was logged, but it was not handled in any other way. The node down handling has had been there, but it has had been deleted in 56d43d5.
If during restart the resources assigned to node change, the driver does not update this. That could lead to outdated information about threads/shards.
In Scylla without this when restarting node with increased assigned resources happen, there was a panic due to wrong number of shards.
I added previously removed marking node as down.
Fixes: scylladb#145