Added Block setting and Shortcode attribute to display Student Account Dashboard as stacked or columns #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed lifterlms_before_student_dashboard action to include layout attribute value.
…umns or stacked dashboard layout.
brianhogg
reviewed
May 8, 2024
|
Sky Pilot related PR that will need merge and release when this goes out (this will break Sky Pilot sites): https://github.com/gocodebox/sky-pilot/pull/115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now allowing people to define a shortcode attribute 'layout' for our Student Dashboard / My Account page shortcode OR for the My Account block.
The attribute accepts 'columns' or 'stacked'. Stacked will maintain the current appearance of the My Account page where the navigation is above the content of the tab.
Columns will display the layout with the navigation in the left column. We can provide people with CSS recipes to have the columns swapped so the nav is on the right side. I feel this is better than supporting more options for the layout attribute, but I am open to it. It isn't a lot of effort to change this to "Navigation Location: Top | Left | Right".
This update also includes adding proper core LifterLMS forms CSS selectors to the "Redeem a Voucher" tab of the My Account page so that the form field and buttons are in line with other forms throughout the frontend.
How has this been tested?
Locally
Note: We should test a bit more with Kadence and Astra - right now they are looking fine when the default attribute is set to stacked. Kadence will not look good with the attribute "columns" since our CSS is getting mixed up with the styling in their customizations
.
Sky Pilot will also need an update. I am going to do that PR and make it dependent on this update being released.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: