Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create required pages on activation #2639

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Apr 23, 2024

NOTE: Verify we also want to create the Course and Membership catalog pages, as this may stop the taxonomy page from working if that's what the user setup

Description

Create the four required pages on activation or update, if they don't already exist.

Fixes #2638

How has this been tested?

Manually

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg marked this pull request as draft May 2, 2024 16:25
@brianhogg
Copy link
Contributor Author

Potential complication is the checkbox for streamlined approach with PMPro would never display. Could see if PMPro can assume they want the streamlined approach on first install?

We could not try to create or modify the course or membership pages of create_pages has happened already.

@ideadude
Copy link
Member

ideadude commented May 9, 2024

FYI here is the code PMPro uses to "streamline" the setup. https://github.com/strangerstudios/paid-memberships-pro/blob/dev/includes/compatibility/lifterlms.php#L397-L435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

None yet

2 participants