Multi restriction warning. #2572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the REST loop, also fixes a failing test
actuallyakash
force-pushed
the
multi-restriction-warning
branch
from
4cd24a0
to
da533c3
Compare
brianhogg
requested changes
May 1, 2024
| } | ||
|
|
||
| // Translators: %s = Membership links. | ||
| $msg = sprintf( |
There was a problem hiding this comment.
We want to keep the messaging as-is if there is only one membership they need to be a member of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, warning is showed for only 1 membership. This PR adds the warning for multiple memberships.
Also see #2523 (comment)
Fixes #2523
How has this been tested?
Manually.
Types of changes
Bug fix
Checklist: