Add inherit option to Course Outline block and increase max number of… #2508
Conversation
There was a problem hiding this comment.
Looks good but I'm not gonna merge this in the upcoming release.
We have the same issue with the Course Information block (not inheriting).
Would be great if for all the blocks that require a course to be specified - or they inherit it from the context (e.g. what if you're in a lesson template?) - we display kind of a placeholder, that mimics the block aspect.
About:
// Show the first course when in Editor if none selected.
What if the first course has no sections?
seothemes
force-pushed
the
course-outline-block
branch
from
811b95a
to
326df90
Compare
There was a problem hiding this comment.
Hey Lee, you must have missed my last review's comment:
Looks good but I'm not gonna merge this in the upcoming release.
We have the same issue with the Course Information block (not inheriting).
Would be great if for all the blocks that require a course to be specified - or they inherit it from the context (e.g. what if you're in a lesson template?) - we display kind of a placeholder, that mimics the block aspect.
About:
// Show the first course when in Editor if none selected.
What if the first course has no sections?
| if ( ! $current_id && llms_is_editor_block_rendering() ) { | ||
| $current_id = LLMS_Shortcodes_Blocks::get_placeholder_course_id(); | ||
| } | ||
|
|
There was a problem hiding this comment.
instead of mixing concepts, can't we have filters so that FROM the blocks shortcode we alter the placeholder course id from there?...
Description
Inherit from current courseoption to Course Outline block when editing Single Course template.How has this been tested?
Manually
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: