Add course continue button, course progress and pricing table blocks #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seothemes
changed the title
usePostOptions react hook
eri-trabiccolo
suggested changes
Aug 7, 2023
| * | ||
| * @param array $atts Associative array of shortcode attributes. | ||
| * @return string | ||
| */ | ||
| public static function course_progress( $atts ) { | ||
|
|
||
| $course_id = self::get_course_id(); | ||
| $course_id = $atts['course_id'] ?? self::get_course_id() ?? null; |
There was a problem hiding this comment.
This is good, but I'd move the block editor related stuff into the class.llms.shortcodes.blocks.php what do you think?
I'd use existing filters or add new ones if needed, but I wouldn't do the checks here.
Same for the pricing table and the course continue button.
There was a problem hiding this comment.
seems you missed this. There's a similar comment on the other PR.
seothemes
force-pushed
the
pricing-table-block
branch
from
e24f77d
to
98d84eb
Compare
eri-trabiccolo
suggested changes
Aug 14, 2023
| * | ||
| * @param array $atts Associative array of shortcode attributes. | ||
| * @return string | ||
| */ | ||
| public static function course_progress( $atts ) { | ||
|
|
||
| $course_id = self::get_course_id(); | ||
| $course_id = $atts['course_id'] ?? self::get_course_id() ?? null; |
There was a problem hiding this comment.
seems you missed this. There's a similar comment on the other PR.
| @@ -601,12 +606,26 @@ public static function pricing_table( $atts ) { | |||
|
|
|||
| if ( ! empty( $atts['product'] ) && is_numeric( $atts['product'] ) ) { | |||
|
|
|||
| // enqueue match height for height alignments. | |||
| $block_editor = llms_is_editor_block_rendering(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds:
with Course ID settings allowing blocks to be used on other post types.
How has this been tested?
Manually
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: