Fixed Error output conflict with Yoast Plugin. #2422
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eri-trabiccolo
suggested changes
Apr 25, 2023
There was a problem hiding this comment.
Hey @actuallyakash
this breaks too many things, see the failing tests.
You're deciding that llms_print_notices should not print notices anymore... but rather show notices at the_content hook.
I think we need a different strategy here...
|
Note for self: A hook in src\integrations\front-end-integration.php on line no. 231 is the issue, which needs to be tackled in the Yoast Plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Yoast plugin stopped the error output from printing out by taking it as a meta description.
Fixes #1779
How has this been tested?
Manually.
Types of changes
Bug fix
Checklist: