-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access plan block editor, access plans block, & @lifterlms/data
module (access plan redux store)
#2062
Draft
thomasplevy
wants to merge
30
commits into
dev
Choose a base branch
from
access-plan-ed
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success147 tests passing in 19 suites.Report generated by 🧪jest coverage report action from 96db42f |
eri-trabiccolo
approved these changes
Mar 11, 2022
…LMS add-ons in the block editor
thomasplevy
changed the title
Access plan block editor, access plans block, & Mar 23, 2022
@lifterlms/data
module and access plan redux store@lifterlms/data
module (access plan redux store)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #2061
Introduces a new module,
@lifterlms/data
which will act as a place to store various LifterLMS-specific react redux stores.This will be exposed as a useable dependency (
llms-data
) that can be referenced by other scripts in order to read and write access plans to the api via the store. Examples and more information to be written.Introduces the access plan store, accessible via
wp.data.select( 'llms/access-plans' )
orwp.data.dispatch( 'llms/access-plans' )
. The store configuration and name can be retrieved viallms.data.accessPlans
.This is the first step towards realizing #2061. In order to power the interface we need to be able to retrieve and persist access plan data to the database (via the rest api) via a redux store. With this in place, we can move onto implementation of the UI overhaul.
How has this been tested?
Types of changes
Checklist: