Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update country/state info #1798

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

update country/state info #1798

wants to merge 2 commits into from

Conversation

thomasplevy
Copy link
Contributor

Description

Locale updates from external databases

How has this been tested?

  • Manually

Screenshots

Types of changes

Data updates

Checklist:

  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@thomasplevy thomasplevy requested a review from a team September 21, 2021 17:36
pondermatic
pondermatic previously approved these changes Sep 21, 2021
'LI' => __( 'O\'Higgins', 'lifterlms' ),
'RM' => __( 'Santiago Metropolitan Region', 'lifterlms' ),
'TA' => __( 'Tarapacá Region', 'lifterlms' ),
'AI' => __( 'Aisén del General Carlos Ibañez del Campo', 'lifterlms' ),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot find any occurrence of "Aisén", "Aysén" seems the correct one.
What's the source of all these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the source of the updates to Chile: dr5hn/countries-states-cities-database#255

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On wikipedia I see that "Aysén" is the official spelling and it is sometimes spelled with an i instead of a y:

The first line has this: https://en.wikipedia.org/wiki/Ays%C3%A9n_Region

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think nobody wiill complain...

Copy link
Collaborator

@eri-trabiccolo eri-trabiccolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I think I'm fine with this, but the truth is that I have no idea :D

@thomasplevy
Copy link
Contributor Author

I'm wondering how we can better manage this... My idea of pulling from an external database was an attempt to relieve us from having to maintain and keep this updated and be the "source" of information. However, it's hard to do because we can't verify and we have to trust the external source.

I'm wondering if we could somehow enlist our international users to help us maintain this through a combination of using the external source and then having updates approved/improved by a representative of that country. For example, @eri-trabiccolo we changed Italian data from the source based on your feedback as an Italian. We have a pending update from a user in Singapore, we were alerted to a potential issue with Germany's states...

There's a lot of ground to cover, of course, and we could elect to just do it manually but that's a lot of work to maintain.

@eri-trabiccolo
Copy link
Collaborator

I'm wondering how we can better manage this... My idea of pulling from an external database was an attempt to relieve us from having to maintain and keep this updated and be the "source" of information. However, it's hard to do because we can't verify and we have to trust the external source.

I'm wondering if we could somehow enlist our international users to help us maintain this through a combination of using the external source and then having updates approved/improved by a representative of that country. For example, @eri-trabiccolo we changed Italian data from the source based on your feedback as an Italian. We have a pending update from a user in Singapore, we were alerted to a potential issue with Germany's states...

There's a lot of ground to cover, of course, and we could elect to just do it manually but that's a lot of work to maintain.

Yeah I think that we discussed this and that was the plan, start from an external source and then wait for feedback.
The problem would be when something updates, are we going to follow the external source or our customer feedback...?
Because either we get the external source as a whole or we don't, right?

@pondermatic
Copy link
Contributor

When we get feedback from users, we should either submit an issue upstream to https://github.com/dr5hn/countries-states-cities-database, or ask our user to.

@eri-trabiccolo
Copy link
Collaborator

When we get feedback from users, we should either submit an issue upstream to https://github.com/dr5hn/countries-states-cities-database, or ask our user to.

It's a little bit hard justify to a customer that, despite we trust them, we're not going to make the change they suggested until a 3rd party lib validates it...

@eri-trabiccolo eri-trabiccolo marked this pull request as draft February 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

None yet

4 participants