Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add europawahl 2024 #9

Closed
wants to merge 1 commit into from

Conversation

cn-ml
Copy link

@cn-ml cn-ml commented May 8, 2024

Resolves #8

I generated this pull request from the current wahl-o-mat 1.0.0 data from may 2nd.
Let me know if there is anything important that i missed.

@gockelhahn
Copy link
Owner

thank you @cn-ml for jumping in when i was unavailable! 👍

in general your commit looks good and working, anyhow i wonder how you generated the json files ... for current wahlomat versions i always use the following script and change/add the link in line 20 before running it:

https://github.com/gockelhahn/qual-o-mat-tools/blob/master/tools/wahlomat_2021.py#L21

unfortunately, i won't merge your PR, because of the following differences/problems:

  • your .json files are formatted differently (no easy diffs)
  • wrong attribute order in opinion.json, it lists statements first and then parties
  • the comment.json has sometimes three backslashes for escaping!?

\\\"racial profiling\\\"

instead:

\"racial profiling\"

@gockelhahn gockelhahn closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wahl-O-Mat for Europawahl 2024
2 participants