No easy way to find previous state

[marclerodrigues]

Closes #263

Before:

previous_state = project.transitions.where(most_recent: false).last.to_state || project.initial_state

After:

project.last_transition.from_state

[danwakefield]

I like the idea.

Is it possible to test if this gracefully falls back when a table does not have the from_state column?
It'd be great if we didn't make table migrations required.

[dmagliola]

Could we have a from_state property on the Transition model, which does something like this, instead of adding a column?

def from_state
  transitions.where(id < self.id).last.to_state
end

Basically, i'm trying to avoid adding the redundant column. If the concern here is the performance hit of an extra DB call, rather than the non-obvious code one needs to write to get the "next-to-last" transition, then this obviously doesn't help.

[marclerodrigues]

@dmagliola The point of this PR is getting the previous state without another DB call.

[marclerodrigues]

@danwakefield I'm afraid this would be a breaking change since I'm making that a required value when transitioning.

What do you think about adding the from_state in the metadata? This way we wouldn't need a new column and would also save another DB call.

We could do that as a "workaround" and push it in a minor change and make the from_state column required in future major versions. Let me know your thoughts on this.

[dmitry]

What about initial state? last_transition returns only second and next states.