Fix witness enter sync map when caller state changes
#1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
Merged
sim642
added
the
pr-dependency
michael-schwarz
approved these changes
May 26, 2024
sim642
removed
the
pr-dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1453.
Turns out this had nothing to do with abortUnless emitting an event from
combine_env(where the crash came from).Rather, it was caused by abortUnless's
enterreturningfalseas the caller state (forcombine_env), rather thanctx.local. The witness lifter assumed it to always bectx.local.abortUnless might be the only analysis which uses this aspect of
enter, which is why this never occurred before.TODO