Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all remaining library functions #1447

Merged
merged 13 commits into from
May 23, 2024
Merged

Port all remaining library functions #1447

merged 13 commits into from
May 23, 2024

Conversation

karoliineh
Copy link
Member

@karoliineh karoliineh commented May 7, 2024

  • Must be thoroughly checked by someone before merging, because the last bit was quite difficult and can likely contain mistakes
  • Revealed some bug: test 02/34 builtin_va_list fails and has to be looked into, something to do with the autotuner:
Fatal error: exception LibraryDsl.Pattern.Expected("Library function is called with more arguments than expected.")
Raised at LibraryDsl.Pattern.fail in file "src/util/library/libraryDsl.ml", line 14, characters 15-33
Called from Goblint_lib__AutoTune.hasFunction.relevant_static.(fun) in file "src/autoTune.ml", line 158, characters 41-60
Called from Stdlib__Map.Make.exists in file "map.ml", line 329, characters 29-34
Called from Goblint_lib__AutoTune.hasFunction in file "src/autoTune.ml", line 175, characters 2-77
Called from Goblint_lib__AutoTune.activateLongjmpAnalysesWhenRequired in file "src/autoTune.ml", line 210, characters 5-26
Called from Dune__exe__Goblint.main in file "src/goblint.ml", line 59, characters 6-53
Called from Stdlib.at_exit.new_exit in file "stdlib.ml", line 560, characters 59-63
Called from Stdlib.do_at_exit in file "stdlib.ml" (inlined), line 566, characters 20-61
Called from Std_exit in file "std_exit.ml", line 18, characters 8-20
See result/index.xml

The latter was caused by the fact that cil has special cases for handling va_arg and va_start functions. Thus, I fixed their argument definitions according to what is written in CIL and left comments.

@karoliineh karoliineh linked an issue May 7, 2024 that may be closed by this pull request
@sim642 sim642 self-requested a review May 8, 2024 10:56
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Outdated Show resolved Hide resolved
src/util/library/libraryFunctions.ml Show resolved Hide resolved
karoliineh and others added 8 commits May 15, 2024 12:03
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
@karoliineh karoliineh requested a review from sim642 May 21, 2024 09:51
@sim642 sim642 added this to the v2.4.0 milestone May 21, 2024
@sim642 sim642 merged commit ac1225a into master May 23, 2024
21 checks passed
@sim642 sim642 deleted the libfuns-final branch May 23, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert all library functions to new specifications
2 participants