Sorting Error List #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine to me but can you squash into a single commit and remove the import changes? |
nilsonsrjunior
force-pushed
the
v2
branch
4 times, most recently
from
6ff6307
to
59bab87
Compare
|
@fastest963 is it ok now ? im new on contributing, so... |
|
Hi, I encountered the same problem so I resolved it by checking error with string contains because not always is required to be too specific about error messages. Also since we have this sorting it will be nice to have also some tests on this. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That can be helpfull with test assertions and might be a problem for the business also, if we always return the error message list in a random order