Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crowdin progress #1587

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: crowdin progress #1587

wants to merge 1 commit into from

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Apr 9, 2024

Fixes the percentages in the locale dropdown on the website.

@andreynering
Copy link
Member

It looks like the build failed. It may not be related to this change, though. Perhaps try a rebase?

https://app.netlify.com/sites/taskfile/deploys/661d2bcac480240078f7fc4e

@andreynering
Copy link
Member

@pd93 This change breaks the local server/build when CROWDIN_PERSONAL_TOKEN is not set. Ideally contributors should be able to compile the server as well, so we need a fallback.

Anyway, translations are simply not working at all, and I decided to disable it, at least temporarily: #1617.

@pd93
Copy link
Member Author

pd93 commented Apr 29, 2024

Anyway, translations are simply not working at all, and I decided to disable it, at least temporarily

@andreynering No problem. I'll mark this as a draft for now and it can be revisited once translations are working again. I'll try to find some time to look into those issues too.

@pd93 pd93 marked this pull request as draft April 29, 2024 21:34
@pd93 pd93 added the status: on hold Work is paused temporarily. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on hold Work is paused temporarily.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants