WIP: validate client params #850
Conversation
| // Validate these params | ||
| func (o *AddCommentToTaskParams) Validate(formats strfmt.Registry) error { | ||
|
|
||
| if err := o.Body.Validate(formats); err != nil { |
There was a problem hiding this comment.
@casualjim this fails to compile, as that body model has not defined the Validate functions. This is however defined for the Body called here: https://github.com/go-swagger/go-swagger/pull/850/files#diff-ab37f2908b4671ebce8d3bc51539d622R123 ; I'm a bit stuck on this one, could you point me to the correct template location on how I could ensure that body model has the validation defined? Or is it because this model is automatically appended in the generator code (via the name+Body stuff)? If i'm doing crazy stuff in this commit you can also point it out though
There was a problem hiding this comment.
That struct should actually have a Validate method, it has 2 required fields, so there is a reason it's not rendering that validate method
There was a problem hiding this comment.
so are you saying, @casualjim, that the reason it is not rendering is an unreported bug?
There was a problem hiding this comment.
yeah that's what it looks like because the same issue exists on the server side
There was a problem hiding this comment.
Ok weird, I'll try to track that issue later today. Can you please also check if my conditionals added in the template are reasonable, as you might have a better idea whether or not those will hold up for all permutations.
| */ | ||
| Body *models.Task | ||
| /*ID | ||
| The id of the item | ||
|
|
||
| Required: true | ||
| In: path | ||
| */ | ||
| ID int64 |
There was a problem hiding this comment.
This ID parameter is required, but for now Required isn't validated in my added Validate Client Parameter code. Any idea how I would be able to add validation for required parameters @casualjim ?
There was a problem hiding this comment.
The biggest question I have with this one, how to check a non-nil value. As I tried some string query parameter as required in a local test API, and it seemed to render as an ordinary string.
There was a problem hiding this comment.
I think there is an issue here: https://github.com/go-swagger/go-swagger/blob/master/generator/operation.go#L903
|
Things left to do in order for the code in this PR to work and thus become merge-able:
|
GlenDC
force-pushed
the
833-validate-client-params
branch
from
dfa3c16
to
a1e6afd
Compare
fixes issue #833