[WIP] 476 lift pointers #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil | ||
| } | ||
|
|
||
| func (m *Item) Clone() *Item { |
There was a problem hiding this comment.
exported method Item.Clone should have comment or be unexported
There was a problem hiding this comment.
exported method Item.Clone should have comment or be unexported
casualjim
force-pushed
the
476-lift-pointers
branch
from
57f5b55
to
df0cc9c
Compare
casualjim
force-pushed
the
476-lift-pointers
branch
from
df0cc9c
to
50a743a
Compare
| /*Item item | ||
|
|
||
| swagger:model item | ||
| */ | ||
| type Item struct { | ||
| __setValues bitset.BitSet | ||
| __nulls bitset.BitSet |
There was a problem hiding this comment.
don't use underscores in Go names; struct field __nulls should be _Nulls
casualjim
force-pushed
the
476-lift-pointers
branch
2 times, most recently
from
09a37dd
to
29eebe4
Compare
casualjim
force-pushed
the
476-lift-pointers
branch
2 times, most recently
from
4046616
to
9c57f4c
Compare
casualjim
force-pushed
the
476-lift-pointers
branch
from
9c57f4c
to
883819d
Compare
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts implementing the items discussed in #476
For this to work we need a custom serializer for all types, not just the "special" ones. So most of the work is around generating a serializer, to a lesser extent it is about pointer/no pointer decisions at render time.