Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an interface for logger #433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Highstead
Copy link

@Highstead Highstead commented Nov 8, 2021

What this does:

Moves from a pointer to a log.logger to a logger interface. I leave in the original code that initializes a default log.logger because this is an older repo and theres no reason to break this.

Why this is necessary

  • I have an older repo (orchestrator) that uses martini and the logs are poluted with martini logs that are in a non standard format and make searching them hard.
  • Also added support for go modules..

- This allows for better support of more modern loggers
- Add support for go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant