Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markup error of lblTitle #2204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix markup error of lblTitle #2204

wants to merge 1 commit into from

Conversation

taoky
Copy link
Contributor

@taoky taoky commented Jan 14, 2024

Recently when auditing my laptop's log, I found that sometimes tilix outputs errors like this:

Jan 14 19:16:46 hostname tilix[602551]: Failed to set text '1: sleep 10 && ls ~' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as &

This could be easily reproduced with fish shell:

> tilix --new-process

And then in the new tilix window (in fish):

> sleep 10 && ls

And you could get this Gtk warning (The GtkLabel inside the GtkBox is also not updated). This PR simply uses setText instead of setMarkup, as it seems that no pango markup is actually used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant