Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position averaging #658

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

vladisslav2011
Copy link
Contributor

While digging through source code, I noticed that class Pvt_Conf contains uint32_t averaging_depth = 1; field and there is unfinished averaging implementation in algorithms/PVT/libs/pvt_solution.cc, so I decided to finish the implementation.

New configuration parameter:
PVT.averaging_depth = 1 - Size of position averaging window. Set to a value <=1 to disable averaging.

@vladisslav2011 vladisslav2011 changed the base branch from main to next August 26, 2022 21:52
@vladisslav2011
Copy link
Contributor Author

Questions:

  1. I have seen bool PVT.flag_averaging configuration parameter in some old config files. Should I implement processing of this parameter too? (Seems useless, as setting PVT.averaging_depth to 1 effectively disables the averaging)
  2. I have implemented another improvement (not included here): a setting, that makes it possible to increase PVT solution rate while keeping PVT output rate low. It may be useful in combination with averaging. Should I open a PR featuring this option (and implementation of it's processing)?

@vladisslav2011
Copy link
Contributor Author

Demonstration: https://www.youtube.com/watch?v=JkJI6KhzN4o

Finish incomplete position averaging implementation.

Configuration parameter:

uint32_t PVT.averaging_depth = 1 - Position averaging window size.
Setting it to a value <=1 disables position averaging.

Signed-off-by: Vladislav P <vladisslav2011@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant